[WIP][SPARK-29779][SQL] Compact old event log files and cleanup - part 2 #27086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
force-pushed
the
SPARK-29779-part2
branch
from
38bffaa
to
c306711
Compare
HeartSaVioR
changed the title
|
#27085 is the part 1 of SPARK-29779 - please review it first. Once we merged the part 1, I'll rebase this patch and remove WIP tag. |
This was referenced Jan 3, 2020
|
Test build #116071 has finished for PR 27086 at commit
|
|
Test build #116074 has finished for PR 27086 at commit
|
|
replaced by #27164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch is the part 2 of SPARK-29779 and only addresses adding filter to handle SQL related events. Please refer the description of PR #27085 to see overall rationalization of this patch.
Below functionalities will be addressed in later parts:
Why are the changes needed?
One of major goal of SPARK-28594 is to prevent the event logs to become too huge, and SPARK-29779 achieves the goal. We've got another approach in prior, but the old approach required models in both KVStore and live entities to guarantee compatibility, while they're not designed to do so.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added UTs.